From: Colin Ian King <colin.king@canonical.com>
Date: Sat, 8 Jun 2019 11:50:31 +0000 (+0100)
Subject: staging: fsl-dpaa2/ethsw: fix memory leak of switchdev_work
X-Git-Tag: v5.3-rc1~126^2~314
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5555ebbbac822b4fa28db2be15aaf98b3c21af26;p=thirdparty%2Fkernel%2Flinux.git

staging: fsl-dpaa2/ethsw: fix memory leak of switchdev_work

In the default event case switchdev_work is being leaked because
nothing is queued for work. Fix this by kfree'ing switchdev_work
before returning NOTIFY_DONE.

Addresses-Coverity: ("Resource leak")
Fixes: 44baaa43d7cc ("staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
index e3c3e427309ab..f73edaf6ce875 100644
--- a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
+++ b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
@@ -1086,6 +1086,7 @@ static int port_switchdev_event(struct notifier_block *unused,
 		dev_hold(dev);
 		break;
 	default:
+		kfree(switchdev_work);
 		return NOTIFY_DONE;
 	}