From: Jiasheng Jiang <jiashengjiangcool@outlook.com>
Date: Tue, 6 Aug 2024 19:18:34 +0000 (+0000)
Subject: test/provider_test.c: Add OSSL_PROVIDER_unload() to avoid memory leak
X-Git-Tag: openssl-3.4.0-alpha1~76
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=55662b674543c9385600bc9b7c46277ef69b4dba;p=thirdparty%2Fopenssl.git

test/provider_test.c: Add OSSL_PROVIDER_unload() to avoid memory leak

Add OSSL_PROVIDER_unload() when OSSL_PROVIDER_add_builtin() fails to avoid memory leak.

Fixes: 5442611dff ("Add a test for OSSL_LIB_CTX_new_child()")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@outlook.com>

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25109)
---

diff --git a/test/provider_test.c b/test/provider_test.c
index 2d20d12071a..3dc5a2109ed 100644
--- a/test/provider_test.c
+++ b/test/provider_test.c
@@ -255,6 +255,7 @@ static int test_builtin_provider_with_child(void)
 
     if (!TEST_true(OSSL_PROVIDER_add_builtin(libctx, name,
                                              PROVIDER_INIT_FUNCTION_NAME))) {
+        OSSL_PROVIDER_unload(legacy);
         OSSL_LIB_CTX_free(libctx);
         return 0;
     }