From: Jouni Malinen <j@w1.fi>
Date: Sun, 26 Jul 2015 09:10:14 +0000 (+0300)
Subject: FST: Remove unnecessary fst_attach() already attached check
X-Git-Tag: hostap_2_5~304
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=55cd405a44f69335e424ee248d1c4ac107b4ca74;p=thirdparty%2Fhostap.git

FST: Remove unnecessary fst_attach() already attached check

Now that both hostapd and wpa_supplicant already enforce no duplicate
fst_attach() calls, there is no need for this check within fst_attach().

Signed-off-by: Jouni Malinen <j@w1.fi>
---

diff --git a/src/fst/fst.c b/src/fst/fst.c
index 347c6fa58..a65b41c54 100644
--- a/src/fst/fst.c
+++ b/src/fst/fst.c
@@ -34,19 +34,6 @@ static void fst_ctrl_iface_notify_peer_state_change(struct fst_iface *iface,
 }
 
 
-static struct fst_group * fst_find_group_by_iface(const char *ifname)
-{
-	struct fst_group *g;
-
-	foreach_fst_group(g) {
-		if (fst_group_get_iface_by_name(g, ifname))
-			return g;
-	}
-
-	return NULL;
-}
-
-
 struct fst_iface * fst_attach(const char *ifname, const u8 *own_addr,
 			      const struct fst_wpa_obj *iface_obj,
 			      const struct fst_iface_cfg *cfg)
@@ -60,14 +47,6 @@ struct fst_iface * fst_attach(const char *ifname, const u8 *own_addr,
 	WPA_ASSERT(iface_obj != NULL);
 	WPA_ASSERT(cfg != NULL);
 
-	g = fst_find_group_by_iface(ifname);
-	if (g) {
-		fst_printf(MSG_ERROR,
-			   "%s: iface is already part of an FST group: %s",
-			   ifname, g->group_id);
-		return NULL;
-	}
-
 	foreach_fst_group(g) {
 		if (os_strcmp(cfg->group_id, fst_group_get_id(g)) == 0) {
 			group = g;