From: Fred Drake <fdrake@acm.org>
Date: Fri, 13 Feb 2004 19:21:57 +0000 (+0000)
Subject: further testing indicates that the simplified version of the test
X-Git-Tag: v2.4a1~822
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=55cf434735380ce51034c64722cf422457f891e0;p=thirdparty%2FPython%2Fcpython.git

further testing indicates that the simplified version of the test
(re-using an existing test object class) no longer triggered the
original segfault when the fix was backed out; restoring the local
test object class to make the test effective

the assignment of the ref created at the end does not affect the test,
since the segfault happended before weakref.ref() returned; removing
the assignment
---

diff --git a/Lib/test/test_weakref.py b/Lib/test/test_weakref.py
index 9ec607eb891e..29243130e7a1 100644
--- a/Lib/test/test_weakref.py
+++ b/Lib/test/test_weakref.py
@@ -602,21 +602,23 @@ class ReferencesTestCase(TestBase):
         thresholds = gc.get_threshold()
         gc.set_threshold(1, 1, 1)
         gc.collect()
+        class A:
+            pass
 
         def callback(*args):
             pass
 
-        referenced = C()
+        referenced = A()
 
-        a = C()
+        a = A()
         a.a = a
         a.wr = makeref(referenced)
 
         try:
             # now make sure the object and the ref get labeled as
             # cyclic trash:
-            a = C()
-            a.wrc = weakref.ref(referenced, callback)
+            a = A()
+            weakref.ref(referenced, callback)
 
         finally:
             gc.set_threshold(*thresholds)