From: Tom Tromey <tromey@adacore.com>
Date: Thu, 4 Sep 2025 15:33:07 +0000 (-0600)
Subject: Don't require "Bss=" in qOffsets response
X-Git-Tag: gdb-17-branchpoint~30
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=55fc9233a835a87d1a9020a8c71c473b03fc4f72;p=thirdparty%2Fbinutils-gdb.git

Don't require "Bss=" in qOffsets response

The "Bss=" part of the qOffsets response is documented as being
optional, but gdb in fact requires it.  This patch fixes the bug.

I couldn't find a straightforward way to test this.  gdbserver does
send 'Bss=' -- but this code is only enabled for a fairly specific
setup:

    #if (defined(__UCLIBC__)		\
	 && defined(HAS_NOMMU)		\
	 && defined(PT_TEXT_ADDR)		\
	 && defined(PT_DATA_ADDR)		\
	 && defined(PT_TEXT_END_ADDR))
    #define SUPPORTS_READ_OFFSETS
    #endif

I also considered changing gdbserver to not send Bss=, but decided
against this, reasoning that we may as well not break compatibility
with older versions of gdb.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33319
Approved-By: Simon Marchi <simon.marchi@efficios.com>
---

diff --git a/gdb/remote.c b/gdb/remote.c
index fb1e88ae678..1d8d9b10339 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -4669,8 +4669,6 @@ remote_target::get_offsets ()
 	  if (bss_addr != data_addr)
 	    warning (_("Target reported unsupported offsets: %s"), buf);
 	}
-      else
-	lose = 1;
     }
   else if (startswith (ptr, "TextSeg="))
     {