From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Sat, 18 May 2019 09:48:47 +0000 (-0700)
Subject: Fixed typo (GH-11522)
X-Git-Tag: v3.7.4rc1~133
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=561c63cd70727e92179018188a9a9c33587fbd3f;p=thirdparty%2FPython%2Fcpython.git

Fixed typo (GH-11522)


Given example does not run, loop variable is missing.

Secondly, this is bad example how to handle shutdown signal, because it would cause `RuntimeError: Event loop stopped before Future completed.`

Perhaps it would be better to cancel all tasks instead of closing loop directly?

Did not create issue, because question is quite simple.
(cherry picked from commit ceb842e155f5fa0109fa88d52da3d1f5e73490ad)

Co-authored-by: Alexander Vasin <hi@alvass.in>
---

diff --git a/Doc/library/asyncio-eventloop.rst b/Doc/library/asyncio-eventloop.rst
index b9a8b8941a46..7e1d571ef59d 100644
--- a/Doc/library/asyncio-eventloop.rst
+++ b/Doc/library/asyncio-eventloop.rst
@@ -1605,7 +1605,7 @@ using the :meth:`loop.add_signal_handler` method::
     import os
     import signal
 
-    def ask_exit(signame):
+    def ask_exit(signame, loop):
         print("got signal %s: exit" % signame)
         loop.stop()
 
@@ -1615,7 +1615,7 @@ using the :meth:`loop.add_signal_handler` method::
         for signame in {'SIGINT', 'SIGTERM'}:
             loop.add_signal_handler(
                 getattr(signal, signame),
-                functools.partial(ask_exit, signame))
+                functools.partial(ask_exit, signame, loop))
 
         await asyncio.sleep(3600)