From: Matt Caswell <matt@openssl.org>
Date: Mon, 31 Jul 2023 11:30:34 +0000 (+0100)
Subject: Always add a suitable error if we fail to decode
X-Git-Tag: openssl-3.2.0-alpha1~335
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=564e5b754a4680dfad38585dd73bcf025567b448;p=thirdparty%2Fopenssl.git

Always add a suitable error if we fail to decode

We're always supposed to add the fallback "unsupported" error if we don't
have anything better. However in some cases this wasn't happening because
we were incorrectly setting "flag_construct_called" - even though the
construct function had failed.

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21603)
---

diff --git a/crypto/encode_decode/decoder_lib.c b/crypto/encode_decode/decoder_lib.c
index d239536175c..3718a696ae3 100644
--- a/crypto/encode_decode/decoder_lib.c
+++ b/crypto/encode_decode/decoder_lib.c
@@ -779,10 +779,11 @@ static int decoder_process(const OSSL_PARAM params[], void *arg)
                            (void *)new_data.ctx, LEVEL, rv);
             } OSSL_TRACE_END(DECODER);
 
-            data->flag_construct_called = 1;
             ok = (rv > 0);
-            if (ok)
+            if (ok) {
+                data->flag_construct_called = 1;
                 goto end;
+            }
         }
 
         /* The constructor didn't return success */