From: Tom Tromey <tromey@adacore.com>
Date: Fri, 17 Jan 2025 17:49:24 +0000 (-0700)
Subject: Fix self-test crash
X-Git-Tag: binutils-2_44~43
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=56535ffb619362d5f492fddc15aa6aaee47baab4;p=thirdparty%2Fbinutils-gdb.git

Fix self-test crash

My earlier changes introduced a self-test crash.  This patch fixes the
bug by introducing a new method overload into mock_mapped_index.
---

diff --git a/gdb/dwarf2/read-gdb-index.c b/gdb/dwarf2/read-gdb-index.c
index 165816f23e7..a9ae741cb81 100644
--- a/gdb/dwarf2/read-gdb-index.c
+++ b/gdb/dwarf2/read-gdb-index.c
@@ -145,7 +145,9 @@ struct mapped_gdb_index : public dwarf_scanner_base
     return symbol_table[2 * idx + 1];
   }
 
-  bool symbol_name_slot_invalid (offset_type idx) const
+  /* Return whether the name at IDX in the symbol table should be
+     ignored.  */
+  virtual bool symbol_name_slot_invalid (offset_type idx) const
   {
     return (symbol_name_index (idx) == 0
 	    && symbol_vec_index (idx) == 0);
@@ -553,6 +555,9 @@ public:
 
   DISABLE_COPY_AND_ASSIGN (mock_mapped_index);
 
+  bool symbol_name_slot_invalid (offset_type idx) const override
+  { return false; }
+
   /* Return the number of names in the symbol table.  */
   size_t symbol_name_count () const override
   {