From: Frédéric Lécaille <flecaille@haproxy.com>
Date: Thu, 6 Jun 2019 12:14:15 +0000 (+0200)
Subject: BUG/MINOR: peers: Wrong server name parsing.
X-Git-Tag: v2.0-dev6~18
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=56aec0ddc6726081547b368ffc0adf7a4a3d95ac;p=thirdparty%2Fhaproxy.git

BUG/MINOR: peers: Wrong server name parsing.

This commit was not complete:
   BUG/MINOR: peers: Wrong "server_name" decoding.
We forgot forgotten to move forward <msg_cur> pointer variable after
having parse the server name string.

Again this bug may happen only if we add stick-table new data type after
the server name which is the current last one. Furthermore this bug is
visible only the first time a peer sends a server name for a stick-table
entry.

Nothing to backport.
---

diff --git a/src/peers.c b/src/peers.c
index f3a465d32e..159f7cedfe 100644
--- a/src/peers.c
+++ b/src/peers.c
@@ -1471,6 +1471,8 @@ static int peer_treat_updatemsg(struct appctx *appctx, struct peer *p, int updt,
 
 				chunk_memcpy(chunk, *msg_cur, value_len);
 				chunk->area[chunk->data] = '\0';
+				*msg_cur += value_len;
+
 				de = dict_insert(&server_name_dict, chunk->area);
 				dc->rx[id - 1].de = de;
 			}