From: Jouni Malinen <j@w1.fi>
Date: Thu, 4 Dec 2014 22:33:31 +0000 (+0200)
Subject: ERP: Avoid a static analyzer warning on uninitialized emsk_len
X-Git-Tag: hostap_2_4~935
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=56b352ec58c9fdcf01c9d3fb94953bc0bd5850ce;p=thirdparty%2Fhostap.git

ERP: Avoid a static analyzer warning on uninitialized emsk_len

This was not really a real issue since bin_clear_free() would not use
the emsk_len argument when emsk is NULL as it would be on the path where
emsk_len has not been initilized. Anyway, it is better to get rid of the
warning.

Signed-off-by: Jouni Malinen <j@w1.fi>
---

diff --git a/src/eap_peer/eap.c b/src/eap_peer/eap.c
index 52e9e312d..6e356c0df 100644
--- a/src/eap_peer/eap.c
+++ b/src/eap_peer/eap.c
@@ -474,7 +474,7 @@ static void eap_peer_erp_init(struct eap_sm *sm)
 {
 #ifdef CONFIG_ERP
 	u8 *emsk = NULL;
-	size_t emsk_len;
+	size_t emsk_len = 0;
 	u8 EMSKname[EAP_EMSK_NAME_LEN];
 	u8 len[2];
 	char *realm;
diff --git a/src/eap_server/eap_server.c b/src/eap_server/eap_server.c
index 53e32c381..bd919e570 100644
--- a/src/eap_server/eap_server.c
+++ b/src/eap_server/eap_server.c
@@ -412,7 +412,7 @@ static void eap_server_erp_init(struct eap_sm *sm)
 {
 #ifdef CONFIG_ERP
 	u8 *emsk = NULL;
-	size_t emsk_len;
+	size_t emsk_len = 0;
 	u8 EMSKname[EAP_EMSK_NAME_LEN];
 	u8 len[2];
 	const char *domain;