From: Arvind Yadav Date: Thu, 16 Nov 2017 04:27:25 +0000 (+0530) Subject: isdn: hisax: Fix pnp_irq's error checking for setup_isurf X-Git-Tag: v4.15-rc1~43^2~13^2~4 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=56cdb919f70abfb353171fd705ab65053f7cc057;p=thirdparty%2Fkernel%2Flinux.git isdn: hisax: Fix pnp_irq's error checking for setup_isurf The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav Signed-off-by: David S. Miller --- diff --git a/drivers/isdn/hisax/isurf.c b/drivers/isdn/hisax/isurf.c index 1399ddd4f6cb3..53e299be43040 100644 --- a/drivers/isdn/hisax/isurf.c +++ b/drivers/isdn/hisax/isurf.c @@ -238,7 +238,7 @@ int setup_isurf(struct IsdnCard *card) cs->hw.isurf.reset = pnp_port_start(pnp_d, 0); cs->hw.isurf.phymem = pnp_mem_start(pnp_d, 1); cs->irq = pnp_irq(pnp_d, 0); - if (!cs->irq || !cs->hw.isurf.reset || !cs->hw.isurf.phymem) { + if (cs->irq == -1 || !cs->hw.isurf.reset || !cs->hw.isurf.phymem) { printk(KERN_ERR "ISurfPnP:some resources are missing %d/%x/%lx\n", cs->irq, cs->hw.isurf.reset, cs->hw.isurf.phymem); pnp_disable_dev(pnp_d);