From: Zijun Hu Date: Mon, 24 Feb 2025 14:27:57 +0000 (+0800) Subject: of: Compare property names by of_prop_cmp() in of_alias_scan() X-Git-Tag: v6.15-rc1~115^2~25 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=56d733bb8f99a572e3b35a307057e019c1974026;p=thirdparty%2Fkernel%2Fstable.git of: Compare property names by of_prop_cmp() in of_alias_scan() For these pseudo property names 'name', 'phandle' and 'linux,phandle': Use dedicated property name comparison macro of_prop_cmp() instead of strcmp() in of_alias_scan() to: - Make property name comparison consistent. - Prepare for introducing private is_pseudo_property() later. Signed-off-by: Zijun Hu Link: https://lore.kernel.org/r/20250224-of_bugfix-v1-1-03640ae8c3a6@quicinc.com Signed-off-by: Rob Herring (Arm) --- diff --git a/drivers/of/base.c b/drivers/of/base.c index af6c68bbb4277..d2d41601136bc 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -1855,9 +1855,9 @@ void of_alias_scan(void * (*dt_alloc)(u64 size, u64 align)) int id, len; /* Skip those we do not want to proceed */ - if (!strcmp(pp->name, "name") || - !strcmp(pp->name, "phandle") || - !strcmp(pp->name, "linux,phandle")) + if (!of_prop_cmp(pp->name, "name") || + !of_prop_cmp(pp->name, "phandle") || + !of_prop_cmp(pp->name, "linux,phandle")) continue; np = of_find_node_by_path(pp->value);