From: drh <>
Date: Thu, 22 Dec 2022 17:36:02 +0000 (+0000)
Subject: Small performance optimization on the OP_Insert opcode.
X-Git-Tag: version-3.41.0~209
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=57366d8cec951518cb34de0600ef45f3672703ce;p=thirdparty%2Fsqlite.git

Small performance optimization on the OP_Insert opcode.

FossilOrigin-Name: 781fdcb9ce85aa2844ef8c00cf908f1a87eeff80dadaf73a71f88b4279260e57
---

diff --git a/manifest b/manifest
index a416ddaffd..b45d071541 100644
--- a/manifest
+++ b/manifest
@@ -1,5 +1,5 @@
-C sessionfuzz.c:\suse\slt/gt\sbrackets\sinstead\sof\sdouble-quotes\swhen\s#including\szlib.h,\sas\sreported\sin\s[forum:91a104bd65\s|\sforum\spost\s91a104bd65].
-D 2022-12-22T10:53:08.958
+C Small\sperformance\soptimization\son\sthe\sOP_Insert\sopcode.
+D 2022-12-22T17:36:02.174
 F .fossil-settings/empty-dirs dbb81e8fc0401ac46a1491ab34a7f2c7c0452f2f06b54ebb845d024ca8283ef1
 F .fossil-settings/ignore-glob 35175cdfcf539b2318cb04a9901442804be81cd677d8b889fcc9149c21f239ea
 F LICENSE.md df5091916dbb40e6e9686186587125e1b2ff51f022cc334e886c19a0e9982724
@@ -717,7 +717,7 @@ F src/upsert.c 5303dc6c518fa7d4b280ec65170f465c7a70b7ac2b22491598f6d0b4875b3145
 F src/utf.c ee39565f0843775cc2c81135751ddd93eceb91a673ea2c57f61c76f288b041a0
 F src/util.c 313f3154e2b85a447326f5dd15de8d31a4df6ab0c3579bd58f426ff634ec9050
 F src/vacuum.c 84ce7f01f8a7a08748e107a441db83bcec13970190ddcb0c9ff522adbc1c23fd
-F src/vdbe.c 5c66a10b2372082fb8eb06caef7617cc23e832a6b689e3163305caee6191da6d
+F src/vdbe.c 03185a27a021df4209dcca057881d56707bdaa926e6c63d65ad6c4ff57f53875
 F src/vdbe.h 73b904a6b3bb27f308c6cc287a5751ebc7f1f89456be0ed068a12b92844c6e8c
 F src/vdbeInt.h 8651e4c4e04d1860d0bdcf330cb8294e3778a9d4222be30ce4c490d9220af783
 F src/vdbeapi.c df3f73a4d0a487f2068e3c84776cd6e3fba5ae80ff612659dcfda4307686420b
@@ -2067,8 +2067,8 @@ F vsixtest/vsixtest.tcl 6a9a6ab600c25a91a7acc6293828957a386a8a93
 F vsixtest/vsixtest.vcxproj.data 2ed517e100c66dc455b492e1a33350c1b20fbcdc
 F vsixtest/vsixtest.vcxproj.filters 37e51ffedcdb064aad6ff33b6148725226cd608e
 F vsixtest/vsixtest_TemporaryKey.pfx e5b1b036facdb453873e7084e1cae9102ccc67a0
-P 371f9b88387a44a5f820279d79733d1deb7eafc72f320ec47a11679bbdbb49ef
-R 628eedf5dffe439daf55d651e55cc62e
-U stephan
-Z 8e36eea40550d456da71194c9dffe516
+P 7d7780c350f3239f9c9feb91924a01a4eba31b88060946c766719c9d50c16bcd
+R a79a9647bde3a72723a187f1de5c75d2
+U drh
+Z caedf858b975dd266664ead43db463b2
 # Remove this line to create a well-formed Fossil manifest.
diff --git a/manifest.uuid b/manifest.uuid
index c2acbc29bc..c783207052 100644
--- a/manifest.uuid
+++ b/manifest.uuid
@@ -1 +1 @@
-7d7780c350f3239f9c9feb91924a01a4eba31b88060946c766719c9d50c16bcd
\ No newline at end of file
+781fdcb9ce85aa2844ef8c00cf908f1a87eeff80dadaf73a71f88b4279260e57
\ No newline at end of file
diff --git a/src/vdbe.c b/src/vdbe.c
index bd8f57791e..bd540e97e9 100644
--- a/src/vdbe.c
+++ b/src/vdbe.c
@@ -5559,8 +5559,11 @@ case OP_Insert: {
   if( pOp->p5 & OPFLAG_ISNOOP ) break;
 #endif
 
-  if( pOp->p5 & OPFLAG_NCHANGE ) p->nChange++;
-  if( pOp->p5 & OPFLAG_LASTROWID ) db->lastRowid = x.nKey;
+  assert( (pOp->p5 & OPFLAG_LASTROWID)==0 || (pOp->p5 & OPFLAG_NCHANGE)!=0 );
+  if( pOp->p5 & OPFLAG_NCHANGE ){
+    p->nChange++;
+    if( pOp->p5 & OPFLAG_LASTROWID ) db->lastRowid = x.nKey;
+  }
   assert( (pData->flags & (MEM_Blob|MEM_Str))!=0 || pData->n==0 );
   x.pData = pData->z;
   x.nData = pData->n;