From: Sylwester Nawrocki Date: Fri, 13 Jul 2012 09:03:15 +0000 (+0900) Subject: ARM: S3C24XX: Free the backlight gpio requested in Mini2440 board code X-Git-Tag: v3.6-rc1~147^2^2~7 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=57370aed40bfb8bfd2daab2eddbdc4faa459e784;p=thirdparty%2Fkernel%2Flinux.git ARM: S3C24XX: Free the backlight gpio requested in Mini2440 board code The backlight gpio must not be left requested in the board code, otherwise s3c24xx_led driver can't successfully claim it. So request the backlight gpio, configure it to proper state and gpio_free right away. This change is required for converting the s3c24xx_led driver to the gpiolib API. Signed-off-by: Sylwester Nawrocki Acked-by: Juergen Beisert Signed-off-by: Kukjin Kim --- diff --git a/arch/arm/mach-s3c24xx/mach-mini2440.c b/arch/arm/mach-s3c24xx/mach-mini2440.c index f092b188ab70a..bd6d2525debef 100644 --- a/arch/arm/mach-s3c24xx/mach-mini2440.c +++ b/arch/arm/mach-s3c24xx/mach-mini2440.c @@ -634,8 +634,8 @@ static void __init mini2440_init(void) s3c_gpio_cfgpin(S3C2410_GPC(0), S3C2410_GPC0_LEND); /* Turn the backlight early on */ - WARN_ON(gpio_request(S3C2410_GPG(4), "backlight")); - gpio_direction_output(S3C2410_GPG(4), 1); + WARN_ON(gpio_request_one(S3C2410_GPG(4), GPIOF_OUT_INIT_HIGH, NULL)); + gpio_free(S3C2410_GPG(4)); /* remove pullup on optional PWM backlight -- unused on 3.5 and 7"s */ s3c_gpio_setpull(S3C2410_GPB(1), S3C_GPIO_PULL_UP);