From: David S. Miller Date: Fri, 29 Mar 2019 00:04:29 +0000 (-0700) Subject: Merge branch 'nfp-fix-retcode-and-disable-netpoll-on-representors' X-Git-Tag: v5.1-rc4~19^2~38 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=577dd43a17b2586bded5b691f30a853e35014a69;p=thirdparty%2Fkernel%2Flinux.git Merge branch 'nfp-fix-retcode-and-disable-netpoll-on-representors' Jakub Kicinski says: ==================== nfp: fix retcode and disable netpoll on representors This series avoids a potential crash on nfp representor devices when netpoll is in use. If transmitting the frame through underlying vNIC fails we'd return an error code (by passing on error code from __dev_queue_xmit()) and cause double free in netpoll code. Fix the error code and disable netpoll on reprs altogether. IRQ-safety of locking the queues and calling __dev_queue_xmit() is questionable. Big thanks to John Hurley for debugging and narrowing down the trace log after I gave up! :) ==================== Signed-off-by: David S. Miller --- 577dd43a17b2586bded5b691f30a853e35014a69