From: Kevin Wolf <kwolf@redhat.com>
Date: Fri, 12 Mar 2010 12:52:31 +0000 (+0100)
Subject: raw-posix: Better error return values for hdev_create
X-Git-Tag: v0.13.0-rc0~963
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=57e69b7d4e270883c7b7adb9c5993bb42e13a5ea;p=thirdparty%2Fqemu.git

raw-posix: Better error return values for hdev_create

Now that we output an error message according to the returned error code in
qemu-img, let's return the real error codes. "Input/output error" for
everything isn't helpful.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---

diff --git a/block/raw-posix.c b/block/raw-posix.c
index 7ce72e9e4e3..ed8db5ed1a0 100644
--- a/block/raw-posix.c
+++ b/block/raw-posix.c
@@ -993,12 +993,12 @@ static int hdev_create(const char *filename, QEMUOptionParameter *options)
 
     fd = open(filename, O_WRONLY | O_BINARY);
     if (fd < 0)
-        return -EIO;
+        return -errno;
 
     if (fstat(fd, &stat_buf) < 0)
-        ret = -EIO;
+        ret = -errno;
     else if (!S_ISBLK(stat_buf.st_mode) && !S_ISCHR(stat_buf.st_mode))
-        ret = -EIO;
+        ret = -ENODEV;
     else if (lseek(fd, 0, SEEK_END) < total_size * 512)
         ret = -ENOSPC;