From: Sami Kerola <kerolasa@iki.fi>
Date: Mon, 20 Feb 2017 22:12:42 +0000 (+0000)
Subject: fdisk, sfdisk: avoid non-ANSI function declarations [smatch scan]
X-Git-Tag: v2.30-rc1~184
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=57ebfde2916f6f3a23ff0defff5a2307ef5ecd12;p=thirdparty%2Futil-linux.git

fdisk, sfdisk: avoid non-ANSI function declarations [smatch scan]

Adding _FUNCTION_DEF definition will exclude compatibility type definitions
that do include void key word in empty argument list.

/usr/include/readline/rltypedefs.h:35:23: warning: non-ANSI function
declaration of function 'Function'

These functions has been replaced by set of new ones in readline 4.2 (April
2001), and removed in 6.3 (February 2014).

Reference: https://cnswww.cns.cwru.edu/php/chet/readline/CHANGES
Rererence: https://blueslugs.com/blog/2016-10-23-updating-cppfunction-in-old-readline-consumers/
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
---

diff --git a/disk-utils/fdisk.c b/disk-utils/fdisk.c
index 4ac58ee4df..f1cd3aa5a5 100644
--- a/disk-utils/fdisk.c
+++ b/disk-utils/fdisk.c
@@ -23,6 +23,7 @@
 #include <limits.h>
 #include <libsmartcols.h>
 #ifdef HAVE_LIBREADLINE
+# define _FUNCTION_DEF
 # include <readline/readline.h>
 #endif
 
diff --git a/disk-utils/sfdisk.c b/disk-utils/sfdisk.c
index cf5dd0052a..46034834a8 100644
--- a/disk-utils/sfdisk.c
+++ b/disk-utils/sfdisk.c
@@ -33,6 +33,7 @@
 #include <fcntl.h>
 #include <libsmartcols.h>
 #ifdef HAVE_LIBREADLINE
+# define _FUNCTION_DEF
 # include <readline/readline.h>
 #endif
 #include <libgen.h>