From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Tue, 29 Jul 2025 07:55:38 +0000 (+0200)
Subject: dnsdist: Fix clang-tidy warnings
X-Git-Tag: dnsdist-2.0.1~16^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=57fa1a74b9f24851f8be1091902492adeb43740c;p=thirdparty%2Fpdns.git

dnsdist: Fix clang-tidy warnings

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit d80362d7d2f1d50d0cd449b62ef7fdea4354eed3)
---

diff --git a/pdns/dnsdistdist/dnsdist-concurrent-connections.cc b/pdns/dnsdistdist/dnsdist-concurrent-connections.cc
index f0e893ba3..776902002 100644
--- a/pdns/dnsdistdist/dnsdist-concurrent-connections.cc
+++ b/pdns/dnsdistdist/dnsdist-concurrent-connections.cc
@@ -96,7 +96,7 @@ static bool checkTCPConnectionsRate(const boost::circular_buffer<ClientActivity>
   uint64_t connectionsSeen = 0;
   uint64_t tlsNewSeen = 0;
   uint64_t tlsResumedSeen = 0;
-  time_t cutOff = now - (interval * 60); // interval is in seconds
+  const auto cutOff = static_cast<time_t>(now - (interval * 60)); // interval is in seconds
   for (const auto& entry : activity) {
     if (entry.bucketEndTime < cutOff) {
       continue;
@@ -139,7 +139,7 @@ void IncomingConcurrentTCPConnectionsManager::cleanup(time_t now)
 
   const auto& immutable = dnsdist::configuration::getImmutableConfiguration();
   const auto interval = immutable.d_tcpConnectionsRatePerClientInterval;
-  time_t cutOff = now - (interval * 60); // interval in minutes
+  const auto cutOff = static_cast<time_t>(now - (interval * 60)); // interval in minutes
   for (auto& shard : s_tcpClientsConnectionMetrics) {
     auto db = shard.lock();
     auto& index = db->get<TimeTag>();