From: Donet Tom Date: Thu, 10 Apr 2025 10:07:48 +0000 (-0500) Subject: selftests/mm: restore default nr_hugepages value during cleanup in hugetlb_reparentin... X-Git-Tag: v6.16-rc1~92^2~171 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=585a9145886ad1d06b39ddcd72d457f37ebb4ff4;p=thirdparty%2Flinux.git selftests/mm: restore default nr_hugepages value during cleanup in hugetlb_reparenting_test.sh During cleanup, the value of /proc/sys/vm/nr_hugepages is currently being set to 0. At the end of the test, if all tests pass, the original nr_hugepages value is restored. However, if any test fails, it remains set to 0. With this patch, we ensure that the original nr_hugepages value is restored during cleanup, regardless of whether the test passes or fails. Link: https://lkml.kernel.org/r/20250410100748.2310-1-donettom@linux.ibm.com Fixes: 29750f71a9b4 ("hugetlb_cgroup: add hugetlb_cgroup reservation tests") Signed-off-by: Donet Tom Cc: Li Wang Cc: "Ritesh Harjani (IBM)" Cc: Shuah Khan Cc: Waiman Long Signed-off-by: Andrew Morton --- diff --git a/tools/testing/selftests/mm/hugetlb_reparenting_test.sh b/tools/testing/selftests/mm/hugetlb_reparenting_test.sh index 9245549b66cfe..0dd31892ff679 100755 --- a/tools/testing/selftests/mm/hugetlb_reparenting_test.sh +++ b/tools/testing/selftests/mm/hugetlb_reparenting_test.sh @@ -56,7 +56,7 @@ function cleanup() { rmdir "$CGROUP_ROOT"/a/b 2>/dev/null rmdir "$CGROUP_ROOT"/a 2>/dev/null rmdir "$CGROUP_ROOT"/test1 2>/dev/null - echo 0 >/proc/sys/vm/nr_hugepages + echo $nr_hugepgs >/proc/sys/vm/nr_hugepages set -e }