From: Rubén Justo <rjusto@gmail.com>
Date: Mon, 22 Apr 2024 22:54:08 +0000 (+0200)
Subject: add-interactive: plug a leak in get_untracked_files
X-Git-Tag: v2.45.0~2^2~2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5861aa84a7a5f393e953203068bd3fc5c710fc42;p=thirdparty%2Fgit.git

add-interactive: plug a leak in get_untracked_files

Plug a leak we have since ab1e1cccaf (built-in add -i: re-implement
`add-untracked` in C, 2019-11-29).

This leak can be triggered with:

	$ echo a | git add -i

As a curiosity, we have a somewhat similar function in builtin/stash.c,
which correctly frees the memory.

Signed-off-by: Rubén Justo <rjusto@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/add-interactive.c b/add-interactive.c
index 6bf87e7ae7..e17602b5e4 100644
--- a/add-interactive.c
+++ b/add-interactive.c
@@ -865,6 +865,7 @@ static int get_untracked_files(struct repository *r,
 	}
 
 	strbuf_release(&buf);
+	dir_clear(&dir);
 	return 0;
 }