From: Pavel Fedin
Date: Thu, 12 Nov 2015 11:55:18 +0000 (+0300)
Subject: net: thunder: Fix crash upon shutdown after failed probe
X-Git-Tag: v4.4-rc2~28^2~47
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5883d9c6d7e680bcdc7a8a9ed2509cd10dd98206;p=thirdparty%2Fkernel%2Flinux.git
net: thunder: Fix crash upon shutdown after failed probe
If device probe fails, driver remains bound to the PCI device. However,
driver data has been reset to NULL. This causes crash upon dereferencing
it in nicvf_remove()
Signed-off-by: Pavel Fedin
Signed-off-by: David S. Miller
---
diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_main.c b/drivers/net/ethernet/cavium/thunder/nicvf_main.c
index a9377727c11c3..372c39e5bcbd8 100644
--- a/drivers/net/ethernet/cavium/thunder/nicvf_main.c
+++ b/drivers/net/ethernet/cavium/thunder/nicvf_main.c
@@ -1600,6 +1600,9 @@ static void nicvf_remove(struct pci_dev *pdev)
static void nicvf_shutdown(struct pci_dev *pdev)
{
+ if (!pci_get_drvdata(pdev))
+ return;
+
nicvf_remove(pdev);
}