From: Alan Modra <amodra@gmail.com>
Date: Tue, 12 Aug 2025 13:16:58 +0000 (+0930)
Subject: Correct readelf thin archive test
X-Git-Tag: gdb-17-branchpoint~325
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=58abb43bc543801662192f2af9efc6aea49cebd3;p=thirdparty%2Fbinutils-gdb.git

Correct readelf thin archive test

If we have an existing archive, the test may fail due to it being the
wrong format.  Also, downloading bintest.thin.a from a remote host
(before creating it!) is wrong.

	* testsuite/binutils-all/readelf.exp (readelf_thin_archive_test):
	Don't remote_download bintest.thin.a.  Delete lib before
	creating.
---

diff --git a/binutils/testsuite/binutils-all/readelf.exp b/binutils/testsuite/binutils-all/readelf.exp
index 571bb9986a1..22f2a355bfd 100644
--- a/binutils/testsuite/binutils-all/readelf.exp
+++ b/binutils/testsuite/binutils-all/readelf.exp
@@ -317,22 +317,21 @@ proc readelf_thin_archive_test {} {
 
     if ![is_remote host] {
 	set tempfile tmpdir/bintest.o
-        set templib  tmpdir/bintest.thin.a
         set libname  tmpdir/bintest.thin.a
     } else {
 	set tempfile [remote_download host tmpdir/bintest.o]
-        set templib  [remote_download host tmpdir/bintest.thin.a]
         set libname  bintest.thin.a
     }
 
     set testname "readelf -h bintest.thin"
+    file_on_host delete $libname
     set got [binutils_run $AR "rcT $libname ${tempfile}"]
     if ![string match "" $got] {
         fail $testname
         return
     }
 
-    readelf_test -h $templib readelf.h.thin
+    readelf_test -h $libname readelf.h.thin
 
     pass $testname
 }