From: Ruediger Meier Date: Sun, 21 Jan 2018 23:04:38 +0000 (+0100) Subject: lsns: fix clang compiler warning X-Git-Tag: v2.32-rc2~26^2~2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=58b29eedb02cdb314a2dc0cfab0397ab54a218f9;p=thirdparty%2Futil-linux.git lsns: fix clang compiler warning ../sys-utils/lsns.c:360:8: warning: comparison of integers of different signs: '__u32' (aka 'unsigned int') and 'int' [-Wsign-compare] if (!(NLMSG_OK(nlh, reslen) ^~~~~~~~~~~~~~~~~~~~~ /usr/include/linux/netlink.h:90:24: note: expanded from macro 'NLMSG_OK' (nlh)->nlmsg_len <= (len)) ~~~~~~~~~~~~~~~~ ^ ~~~ Signed-off-by: Ruediger Meier --- diff --git a/sys-utils/lsns.c b/sys-utils/lsns.c index d36269df54..9f99152a49 100644 --- a/sys-utils/lsns.c +++ b/sys-utils/lsns.c @@ -347,7 +347,8 @@ static int get_netnsid_via_netlink_recv_response(int *netnsid) < RTA_SPACE(sizeof(struct nlmsgerr))) ? RTA_SPACE(sizeof(struct nlmsgerr)) : RTA_SPACE(sizeof(int32_t)))]; - int reslen, rtalen; + int rtalen; + ssize_t reslen; struct nlmsghdr *nlh; struct rtattr *rta; @@ -357,7 +358,7 @@ static int get_netnsid_via_netlink_recv_response(int *netnsid) return -1; nlh = (struct nlmsghdr *)res; - if (!(NLMSG_OK(nlh, reslen) + if (!(NLMSG_OK(nlh, (size_t)reslen) && nlh->nlmsg_type == RTM_NEWNSID)) return -1;