From: Ján Tomko <jtomko@redhat.com>
Date: Fri, 14 Jun 2019 07:14:53 +0000 (+0200)
Subject: api: disallow virDomainManagedSaveDefineXML on read-only connections
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=58c7c3fc4a0f15544c2054ed4682ff5d740681ab;p=thirdparty%2Flibvirt.git

api: disallow virDomainManagedSaveDefineXML on read-only connections

The virDomainManagedSaveDefineXML can be used to alter the domain's
config used for managedsave or even execute arbitrary emulator binaries.
Forbid it on read-only connections.

Fixes: CVE-2019-10166
Reported-by: Matthias Gerstner <mgerstner@suse.de>
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
(cherry picked from commit db0b78457f183e4c7ac45bc94de86044a1e2056a)
Signed-off-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index ba0aaccdc1..ac7c4708b9 100644
--- a/src/libvirt-domain.c
+++ b/src/libvirt-domain.c
@@ -9565,6 +9565,7 @@ virDomainManagedSaveDefineXML(virDomainPtr domain, const char *dxml,
 
     virCheckDomainReturn(domain, -1);
     conn = domain->conn;
+    virCheckReadOnlyGoto(conn->flags, error);
 
     if (conn->driver->domainManagedSaveDefineXML) {
         int ret;