From: Andrei Rybak Date: Mon, 17 Apr 2023 19:10:42 +0000 (+0200) Subject: t1450: don't create unused files X-Git-Tag: v2.41.0-rc0~29^2~2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=59162ece57738dfd928093251d4e95d87825ecf9;p=thirdparty%2Fgit.git t1450: don't create unused files Test 'fsck error and recovery on invalid object type' in file t1450-fsck.sh redirects output of a failing "git fsck" invocation to files "out" and "err" to assert presence of error messages in the output of the command. Commit 31deb28f5e (fsck: don't hard die on invalid object types, 2021-10-01) changed the way assertions in this test are performed. The test doesn't compare the whole standard error with prepared file "err.expect" and it doesn't assert that standard output is empty. Don't create unused files "err.expect" and "out" in test 'fsck error and recovery on invalid object type'. Signed-off-by: Andrei Rybak Reviewed-by: Elijah Newren Signed-off-by: Junio C Hamano --- diff --git a/t/t1450-fsck.sh b/t/t1450-fsck.sh index fdb886dfe4..f49f878fdc 100755 --- a/t/t1450-fsck.sh +++ b/t/t1450-fsck.sh @@ -989,10 +989,7 @@ test_expect_success 'fsck error and recovery on invalid object type' ' garbage_blob=$(git hash-object --stdin -w -t garbage --literally err.expect <<-\EOF && - fatal: invalid object type - EOF - test_must_fail git fsck >out 2>err && + test_must_fail git fsck 2>err && grep -e "^error" -e "^fatal" err >errors && test_line_count = 1 errors && grep "$garbage_blob: object is of unknown type '"'"'garbage'"'"':" err