From: Jean-Philippe Menil <jpmenil@gmail.com>
Date: Thu, 25 Mar 2021 16:21:24 +0000 (+0100)
Subject: openssl: ensure to check SSL_CTX_set_alpn_protos return values
X-Git-Tag: curl-7_76_0~22
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5930cb1c465ef5f0de6f1b91a843bb6f0bed1f23;p=thirdparty%2Fcurl.git

openssl: ensure to check SSL_CTX_set_alpn_protos return values

SSL_CTX_set_alpn_protos() return 0 on success, and non-0 on failure

Signed-off-by: Jean-Philippe Menil <jpmenil@gmail.com>

Closes #6794
---

diff --git a/lib/vtls/openssl.c b/lib/vtls/openssl.c
index a9690383dd..498f8b9d1d 100644
--- a/lib/vtls/openssl.c
+++ b/lib/vtls/openssl.c
@@ -2749,7 +2749,10 @@ static CURLcode ossl_connect_step1(struct Curl_easy *data,
     /* expects length prefixed preference ordered list of protocols in wire
      * format
      */
-    SSL_CTX_set_alpn_protos(backend->ctx, protocols, cur);
+    if(SSL_CTX_set_alpn_protos(backend->ctx, protocols, cur)) {
+      failf(data, "Error setting ALPN");
+      return CURLE_SSL_CONNECT_ERROR;
+    }
   }
 #endif