From: Pedro Alves Date: Tue, 20 Feb 2024 16:31:39 +0000 (+0000) Subject: Fix throw_winerror_with_name build error on x86-64 Cygwin X-Git-Tag: gdb-15-branchpoint~895 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=593318f69b481f32f2a06093d2b9660b4fb77f24;p=thirdparty%2Fbinutils-gdb.git Fix throw_winerror_with_name build error on x86-64 Cygwin The GDB build currently fails on x86-64 Cygwin, with: src/gdbsupport/errors.cc: In function ‘void throw_winerror_with_name(const char*, ULONGEST)’: src/gdbsupport/errors.cc:152:12: error: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘ULONGEST’ {aka ‘long unsigned int’} [-Werror=format=] 152 | error (_("%s (error %d): %s"), string, err, strwinerror (err)); | ^ Fix this by adding a cast. While at it, the error codes are really a DWORD that results from a GetLastError() call, so I think unsigned is more appropriate. That is also what strwinerror already does: sprintf (buf, "unknown win32 error (%u)", (unsigned) error); The cast is necessary on MinGW GDB as well, where ULONGEST is unsigned long long, but for some reason, I don't get a warning there. Approved-By: Tom Tromey Change-Id: I3f5faa779765fd8021abf58bb5f68d556b309d17 --- diff --git a/gdbsupport/errors.cc b/gdbsupport/errors.cc index 8ac3ed0da79..cccdc5cafb2 100644 --- a/gdbsupport/errors.cc +++ b/gdbsupport/errors.cc @@ -149,7 +149,7 @@ strwinerror (ULONGEST error) void throw_winerror_with_name (const char *string, ULONGEST err) { - error (_("%s (error %d): %s"), string, err, strwinerror (err)); + error (_("%s (error %u): %s"), string, (unsigned) err, strwinerror (err)); } #endif /* USE_WIN32API */