From: Viktor Szakats Date: Thu, 14 Aug 2025 14:45:15 +0000 (+0200) Subject: GHA/linux: try improving valgrind job times with cmake X-Git-Tag: curl-8_16_0~177 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=596383ca7165a4ec3a1774941bf7b90d4c2d1256;p=thirdparty%2Fcurl.git GHA/linux: try improving valgrind job times with cmake Make the: - mbedTLS valgrind job finish under 14m, vs 15m before. - OpenSSL -O3 valgrind job finish in 14m30, vs 16m17. - OpenSSL libssh2 valgrind job finish in 16m, vs 17m30. - long valgrind rustls job finish 1 minute earlier, in return for spending 30s more on the other rustls job. Keep using autotools for the less slow valgrind job to test this combo. Closes #18290 --- diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml index 7f1ea5a5eb..9c5248449b 100644 --- a/.github/workflows/linux.yml +++ b/.github/workflows/linux.yml @@ -103,7 +103,12 @@ jobs: - name: 'mbedtls valgrind' install_packages: libnghttp2-dev libidn2-dev libldap-dev valgrind install_steps: mbedtls - configure: LDFLAGS=-Wl,-rpath,/home/runner/mbedtls/lib --with-mbedtls=/home/runner/mbedtls --enable-debug + generate: >- + -DCURL_USE_MBEDTLS=ON -DENABLE_DEBUG=ON + -DMBEDTLS_INCLUDE_DIR=/home/runner/mbedtls/include + -DMBEDTLS_LIBRARY=/home/runner/mbedtls/lib/libmbedtls.a + -DMBEDX509_LIBRARY=/home/runner/mbedtls/lib/libmbedx509.a + -DMBEDCRYPTO_LIBRARY=/home/runner/mbedtls/lib/libmbedcrypto.a - name: 'mbedtls clang' install_packages: libnghttp2-dev libldap-dev clang @@ -145,7 +150,7 @@ jobs: - name: 'openssl libssh2 sync-resolver valgrind' install_packages: zlib1g-dev libidn2-dev libssh2-1-dev libnghttp2-dev libldap-dev valgrind - configure: --with-openssl --enable-debug --disable-threaded-resolver --with-libssh2 + generate: -DENABLE_DEBUG=ON -DENABLE_THREADED_RESOLVER=OFF -DCURL_USE_LIBSSH2=ON - name: 'openssl' install_packages: zlib1g-dev @@ -160,7 +165,8 @@ jobs: - name: 'openssl -O3 libssh valgrind' install_packages: zlib1g-dev libssh-dev valgrind - configure: CFLAGS=-O3 --with-openssl --enable-debug --with-libssh + CFLAGS: -O3 + generate: -DENABLE_DEBUG=ON -DCURL_USE_LIBSSH=ON - name: 'openssl clang krb5 openldap static' install_steps: openldap-static @@ -260,12 +266,12 @@ jobs: - name: 'rustls valgrind' install_packages: libnghttp2-dev libldap-dev valgrind install_steps: rust rustls - configure: --with-rustls --enable-ech --enable-debug + generate: -DCURL_USE_RUSTLS=ON -DUSE_ECH=ON -DENABLE_DEBUG=ON - name: 'rustls' install_packages: libnghttp2-dev libldap-dev install_steps: rust rustls skiprun pytest - generate: -DCURL_USE_RUSTLS=ON -DUSE_ECH=ON -DENABLE_DEBUG=ON + configure: --with-rustls --enable-ech --enable-debug - name: 'IntelC openssl' install_packages: zlib1g-dev libssl-dev