From: Tom Lane Date: Thu, 14 Apr 2005 21:44:22 +0000 (+0000) Subject: Don't try to constant-fold functions returning RECORD, since the optimizer X-Git-Tag: REL8_0_3~44 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=59974b0e0ae8cd48c20642d571a69d5e3b7b29d0;p=thirdparty%2Fpostgresql.git Don't try to constant-fold functions returning RECORD, since the optimizer isn't presently set up to pass them an expected tuple descriptor. Bug has been there since 7.3 but was just recently reported by Thomas Hallgren. --- diff --git a/src/backend/optimizer/util/clauses.c b/src/backend/optimizer/util/clauses.c index a43256cc1f2..2c1b43266f8 100644 --- a/src/backend/optimizer/util/clauses.c +++ b/src/backend/optimizer/util/clauses.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/optimizer/util/clauses.c,v 1.186.4.3 2005/04/10 20:57:45 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/optimizer/util/clauses.c,v 1.186.4.4 2005/04/14 21:44:22 tgl Exp $ * * HISTORY * AUTHOR DATE MAJOR EVENT @@ -2043,6 +2043,13 @@ evaluate_function(Oid funcid, Oid result_type, List *args, if (funcform->proretset) return NULL; + /* + * Can't simplify if it returns RECORD, since it will be needing an + * expected tupdesc which we can't supply here. + */ + if (funcform->prorettype == RECORDOID) + return NULL; + /* * Check for constant inputs and especially constant-NULL inputs. */