From: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Date: Mon, 6 Nov 2023 15:00:28 +0000 (+0000)
Subject: hw/core/loader: gunzip(): initialize z_stream
X-Git-Tag: v8.2.0-rc0~28^2~3
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=59a3aff685fdb930244c7aa439e121b60e50f266;p=thirdparty%2Fqemu.git

hw/core/loader: gunzip(): initialize z_stream

Coverity signals that variable as being used uninitialized. And really,
when work with external APIs that's better to zero out the structure,
where we set some fields by hand.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Maksim Davydov <davydov-max@yandex-team.ru>
Message-id: 20231017125941.810461-6-vsementsov@yandex-team.ru
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---

diff --git a/hw/core/loader.c b/hw/core/loader.c
index 4dd5a71fb79..b7bb44b7f7c 100644
--- a/hw/core/loader.c
+++ b/hw/core/loader.c
@@ -558,7 +558,7 @@ static void zfree(void *x, void *addr)
 
 ssize_t gunzip(void *dst, size_t dstlen, uint8_t *src, size_t srclen)
 {
-    z_stream s;
+    z_stream s = {};
     ssize_t dstbytes;
     int r, i, flags;