From: Tom Tromey <tom@tromey.com>
Date: Sat, 11 Jan 2025 21:34:06 +0000 (-0700)
Subject: Remove "enabled" output from show_index_cache_command
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=59d2fac1004a9d6b75ebb52b8faacffed1704021;p=thirdparty%2Fbinutils-gdb.git

Remove "enabled" output from show_index_cache_command

show_index_cache_command prints whether the index-cache is enabled.
This text was added back in 2018 in commit 87d6a7aa (Add DWARF index
cache).  Then in 2021, the enabling option was changed via commit
7bc5c369 (gdb: introduce "set index-cache enabled", deprecate "set
index-cache on/off").

This latter change made this output, IMO, redundant.  That is,
currently gdb will show:

    (gdb) show index-cache
    ...
    index-cache enabled:  The index cache is off.
    ...
    The index cache is currently disabled.

This patch removes the redundant output.
---

diff --git a/gdb/dwarf2/index-cache.c b/gdb/dwarf2/index-cache.c
index a04d5d662d8..d34abf373f8 100644
--- a/gdb/dwarf2/index-cache.c
+++ b/gdb/dwarf2/index-cache.c
@@ -280,11 +280,6 @@ show_index_cache_command (const char *arg, int from_tty)
 
   /* Call all "show index-cache" subcommands.  */
   cmd_show_list (show_index_cache_prefix_list, from_tty);
-
-  gdb_printf ("\n");
-  gdb_printf
-    (_("The index cache is currently %s.\n"),
-     global_index_cache.enabled () ? _("enabled") : _("disabled"));
 }
 
 /* "set/show index-cache enabled" set callback.  */