From: Harshit Mogalapalli Date: Tue, 21 Jan 2025 00:50:02 +0000 (-0800) Subject: net: mvneta: fix locking in mvneta_cpu_online() X-Git-Tag: v6.14-rc1~33^2~41 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=59e00e8ca24220acea2d2d9f540fccf64e0f41ea;p=thirdparty%2Fkernel%2Flinux.git net: mvneta: fix locking in mvneta_cpu_online() When port is stopped, unlock before returning Fixes: 413f0271f396 ("net: protect NAPI enablement with netdev_lock()") Signed-off-by: Harshit Mogalapalli Reviewed-by: Simon Horman Link: https://patch.msgid.link/20250121005002.3938236-1-harshit.m.mogalapalli@oracle.com Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index 82f4333fb426c..4fe121b9f94b6 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -4432,6 +4432,7 @@ static int mvneta_cpu_online(unsigned int cpu, struct hlist_node *node) */ if (pp->is_stopped) { spin_unlock(&pp->lock); + netdev_unlock(port->napi.dev); return 0; } netif_tx_stop_all_queues(pp->dev);