From: Amaury Denoyelle <adenoyelle@haproxy.com>
Date: Wed, 16 Oct 2024 09:05:51 +0000 (+0200)
Subject: MINOR: quic: notify connection layer on handshake completion
X-Git-Tag: v3.1-dev10~66
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5a5950e42d7060ee311e51438f4f16ad0effefd9;p=thirdparty%2Fhaproxy.git

MINOR: quic: notify connection layer on handshake completion

Wake up connection layer on QUIC handshake completion via
quic_conn_io_cb. Select SUB_RETRY_RECV as this was previously unused by
QUIC MUX layer.

For the moment, QUIC MUX never subscribes for handshake completion.
However, this will be necessary for features such as the delaying of
early data forwarding via wait-for-handshake.

This patch will be necessary to implement wait-for-handshake support for
QUIC. As such, it must be backported with next commits up to 2.6,
after a mandatory period of observation.
---

diff --git a/src/mux_quic.c b/src/mux_quic.c
index 13b058e071..e87b97e472 100644
--- a/src/mux_quic.c
+++ b/src/mux_quic.c
@@ -2701,7 +2701,8 @@ struct task *qcc_io_cb(struct task *t, void *ctx, unsigned int status)
 
 	TRACE_ENTER(QMUX_EV_QCC_WAKE, qcc->conn);
 
-	qcc_io_send(qcc);
+	if (!(qcc->wait_event.events & SUB_RETRY_SEND))
+		qcc_io_send(qcc);
 
 	qcc_io_recv(qcc);
 
diff --git a/src/quic_conn.c b/src/quic_conn.c
index 37eaf940b2..9701eaab2e 100644
--- a/src/quic_conn.c
+++ b/src/quic_conn.c
@@ -861,6 +861,14 @@ struct task *quic_conn_io_cb(struct task *t, void *context, unsigned int state)
 			 * TODO implement discarding of 0-RTT keys
 			 */
 		}
+
+		/* Wake up connection layer if on wait-for-handshake. */
+		if (qc->subs && qc->subs->events & SUB_RETRY_RECV) {
+			tasklet_wakeup(qc->subs->tasklet);
+			qc->subs->events &= ~SUB_RETRY_RECV;
+			if (!qc->subs->events)
+				qc->subs = NULL;
+		}
 	}
 
 	/* Insert each QEL into sending list if needed. */