From: Michael Tokarev Date: Wed, 6 Aug 2025 07:48:37 +0000 (+0300) Subject: tests/qemu-iotests/tests/mirror-sparse: actually require O_DIRECT X-Git-Tag: v10.1.0-rc3~11^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5a5d18c75666378ff5db70268dbd39bd38488f21;p=thirdparty%2Fqemu.git tests/qemu-iotests/tests/mirror-sparse: actually require O_DIRECT Commit c0ddcb2cbc146e introduced the test which uses cache=direct mode, without checking if the scratch filesystem supports O_DIRECT. A subsequent commit, afeb002e0ad49d, tried to fix that issue, but instead of checking for o_direct, it checked for `_supported_cache_modes none directsync`, which is not what the original mirror-sparse test uses. Fix both by actually checking for o_direct. Fixes: c0ddcb2cbc146e "tests: Add iotest mirror-sparse for recent patches" Fixes: afeb002e0ad49d "tests/qemu-iotests/tests/mirror-sparse: skip if O_DIRECT is not supported" Reviewed-by: Stefan Hajnoczi Signed-off-by: Michael Tokarev --- diff --git a/tests/qemu-iotests/tests/mirror-sparse b/tests/qemu-iotests/tests/mirror-sparse index 3b183eea88a..ee7101bd50e 100755 --- a/tests/qemu-iotests/tests/mirror-sparse +++ b/tests/qemu-iotests/tests/mirror-sparse @@ -40,7 +40,7 @@ cd .. _supported_fmt qcow2 raw # Format of the source. dst is always raw file _supported_proto file _supported_os Linux -_supported_cache_modes none directsync +_require_o_direct _require_disk_usage echo