From: Sergio Perez Gonzalez Date: Sun, 16 Mar 2025 05:46:06 +0000 (-0600) Subject: spi: spi-mux: Fix coverity issue, unchecked return value X-Git-Tag: v6.15-rc1~182^2~8 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5a5fc308418aca275a898d638bc38c093d101855;p=thirdparty%2Fkernel%2Flinux.git spi: spi-mux: Fix coverity issue, unchecked return value The return value of spi_setup() is not captured within spi_mux_select() and it is assumed to be always success. CID: 1638374 Signed-off-by: Sergio Perez Gonzalez Link: https://patch.msgid.link/20250316054651.13242-1-sperezglz@gmail.com Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi-mux.c b/drivers/spi/spi-mux.c index c02c4204442f5..0eb35c4e3987e 100644 --- a/drivers/spi/spi-mux.c +++ b/drivers/spi/spi-mux.c @@ -68,9 +68,7 @@ static int spi_mux_select(struct spi_device *spi) priv->current_cs = spi_get_chipselect(spi, 0); - spi_setup(priv->spi); - - return 0; + return spi_setup(priv->spi); } static int spi_mux_setup(struct spi_device *spi)