From: Christophe JAILLET Date: Tue, 29 Oct 2024 12:31:49 +0000 (+0100) Subject: mfd: cgbc-core: Fix error handling paths in cgbc_init_device() X-Git-Tag: v6.13-rc1~113^2~13 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5a700e77d6458e838b4882627771cc5f367827af;p=thirdparty%2Fkernel%2Flinux.git mfd: cgbc-core: Fix error handling paths in cgbc_init_device() If an error occurs after a cgbc_session_request() call, it should be balanced by a corresponding cgbc_session_release(), as already done in the remove function. Fixes: 6f1067cfbee7 ("mfd: Add Congatec Board Controller driver") Signed-off-by: Christophe JAILLET Reviewed-by: Thomas Richard Link: https://lore.kernel.org/r/83194335554146efc52c331993f083bd765db6f9.1730205085.git.christophe.jaillet@wanadoo.fr Signed-off-by: Lee Jones --- diff --git a/drivers/mfd/cgbc-core.c b/drivers/mfd/cgbc-core.c index ac3042fd5aa16..85283c8dde253 100644 --- a/drivers/mfd/cgbc-core.c +++ b/drivers/mfd/cgbc-core.c @@ -321,9 +321,18 @@ static int cgbc_init_device(struct cgbc_device_data *cgbc) ret = cgbc_get_version(cgbc); if (ret) - return ret; + goto release_session; + + ret = mfd_add_devices(cgbc->dev, -1, cgbc_devs, ARRAY_SIZE(cgbc_devs), + NULL, 0, NULL); + if (ret) + goto release_session; - return mfd_add_devices(cgbc->dev, -1, cgbc_devs, ARRAY_SIZE(cgbc_devs), NULL, 0, NULL); + return 0; + +release_session: + cgbc_session_release(cgbc); + return ret; } static int cgbc_probe(struct platform_device *pdev)