From: Philippe Mathieu-Daudé Date: Fri, 19 Jul 2019 13:14:22 +0000 (+0200) Subject: hw/ipmi: Rewrite a fall through comment X-Git-Tag: v4.2.0-rc0~221^2~5 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5a70b8b550a8e236fd7f696c803fc05c4cae2a54;p=thirdparty%2Fqemu.git hw/ipmi: Rewrite a fall through comment GCC9 is confused by this comment when building with CFLAG -Wimplicit-fallthrough=2: hw/ipmi/ipmi_bmc_extern.c: In function ‘addchar’: hw/ipmi/ipmi_bmc_extern.c:178:12: error: this statement may fall through [-Werror=implicit-fallthrough=] 178 | ch |= 0x10; | ~~~^~~~~~~ hw/ipmi/ipmi_bmc_extern.c:181:5: note: here 181 | default: | ^~~~~~~ cc1: all warnings being treated as errors make: *** [rules.mak:69: hw/ipmi/ipmi_bmc_extern.o] Error 1 Rewrite the comment using 'fall through' which is recognized by GCC and static analyzers. Reported-by: Stefan Weil Signed-off-by: Philippe Mathieu-Daudé Acked-by: Corey Minyard Message-Id: <20190719131425.10835-5-philmd@redhat.com> Signed-off-by: Laurent Vivier --- diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c index 573428eca1b..87da9ff99cf 100644 --- a/hw/ipmi/ipmi_bmc_extern.c +++ b/hw/ipmi/ipmi_bmc_extern.c @@ -177,8 +177,7 @@ static void addchar(IPMIBmcExtern *ibe, unsigned char ch) ibe->outbuf[ibe->outlen] = VM_ESCAPE_CHAR; ibe->outlen++; ch |= 0x10; - /* No break */ - + /* fall through */ default: ibe->outbuf[ibe->outlen] = ch; ibe->outlen++;