From: Adolf Belka <adolf.belka@ipfire.org>
Date: Mon, 11 Mar 2024 12:19:08 +0000 (+0100)
Subject: dns.cgi: Revert "dns.cgi: Fixes bug#12395 - German umlauts not correctly displayed... 
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5a7342fc285425d226e52d988c0e35c23cd7547b;p=people%2Fms%2Fipfire-2.x.git

dns.cgi: Revert "dns.cgi: Fixes bug#12395 - German umlauts not correctly displayed in remarks"

- This reverts commit 7c6ff5ff12331a53f416080a44c8d6145e78bfac
- That commit removed the cleanhtml command which is not advised, based on feedback from
   Michael Tremer from other patch submissions as it creates a potential security problem.

Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/html/cgi-bin/dns.cgi b/html/cgi-bin/dns.cgi
index f3dd5c7a9..0a34d3fd6 100644
--- a/html/cgi-bin/dns.cgi
+++ b/html/cgi-bin/dns.cgi
@@ -141,6 +141,8 @@ if (($cgiparams{'SERVERS'} eq $Lang::tr{'save'}) || ($cgiparams{'SERVERS'} eq $L
 
 	# Go further if there was no error.
 	if ( ! $errormessage) {
+		# Check if a remark has been entered.
+		$cgiparams{'REMARK'} = &Header::cleanhtml($cgiparams{'REMARK'});
 
 		my %dns_servers = ();
 		my $id;