From: Denton Liu <liu.denton@gmail.com>
Date: Wed, 25 Mar 2020 05:54:48 +0000 (-0400)
Subject: t5512: don't use `test_must_fail test_cmp`
X-Git-Tag: v2.27.0-rc0~134^2~7
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5a85a25e3528cf94a89861800eb4b939408792e3;p=thirdparty%2Fgit.git

t5512: don't use `test_must_fail test_cmp`

The test_must_fail function should only be used for git commands since
we should assume that external commands work sanely. Since test_cmp() just
wraps an external command, replace `test_must_fail test_cmp` with
`! test_cmp`.

Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/t/t5512-ls-remote.sh b/t/t5512-ls-remote.sh
index 04b35402c7..08b98f12b8 100755
--- a/t/t5512-ls-remote.sh
+++ b/t/t5512-ls-remote.sh
@@ -92,7 +92,7 @@ test_expect_success 'use "origin" when no remote specified' '
 
 test_expect_success 'suppress "From <url>" with -q' '
 	git ls-remote -q 2>actual_err &&
-	test_must_fail test_cmp exp_err actual_err
+	! test_cmp exp_err actual_err
 '
 
 test_expect_success 'use branch.<name>.remote if possible' '