From: Willy Tarreau <w@1wt.eu>
Date: Tue, 11 Jun 2019 14:01:56 +0000 (+0200)
Subject: BUG/MINOR: http-rules: mention "deny_status" for "deny" in the error message
X-Git-Tag: v2.0-dev7~8
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5abdc760c99a0011607f2cc97e199ef6ce0e8486;p=thirdparty%2Fhaproxy.git

BUG/MINOR: http-rules: mention "deny_status" for "deny" in the error message

The error message indicating an unknown keyword on an http-request rule
doesn't mention the "deny_status" option which comes with the "deny" rule,
this is particularly confusing.

This can be backported to all versions supporting this option.
---

diff --git a/src/http_rules.c b/src/http_rules.c
index ab01f264c1..508920020d 100644
--- a/src/http_rules.c
+++ b/src/http_rules.c
@@ -556,7 +556,8 @@ struct act_rule *parse_http_req_cond(const char **args, const char *file, int li
 		rule->cond = cond;
 	}
 	else if (*args[cur_arg]) {
-		ha_alert("parsing [%s:%d]: 'http-request %s' expects 'realm' for 'auth' or"
+		ha_alert("parsing [%s:%d]: 'http-request %s' expects 'realm' for 'auth',"
+			 " 'deny_status' for 'deny', or"
 			 " either 'if' or 'unless' followed by a condition but found '%s'.\n",
 			 file, linenum, args[0], args[cur_arg]);
 		goto out_err;