From: Jouni Malinen <j@w1.fi>
Date: Sat, 23 Feb 2019 16:02:16 +0000 (+0200)
Subject: atheros: Avoid clang compiler warning on address of array check
X-Git-Tag: hostap_2_8~318
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5ac13f6d00acb7e80f3387b58923029a3ac412b9;p=thirdparty%2Fhostap.git

atheros: Avoid clang compiler warning on address of array check

ie.wps_ie is an array, so there is no point in checking whether it is
NULL.

driver_atheros.c:1221:9: error: address of array 'ie.wps_ie' will
      always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]

Signed-off-by: Jouni Malinen <j@w1.fi>
---

diff --git a/src/drivers/driver_atheros.c b/src/drivers/driver_atheros.c
index 62f5baad6..807cd9469 100644
--- a/src/drivers/driver_atheros.c
+++ b/src/drivers/driver_atheros.c
@@ -1218,8 +1218,7 @@ atheros_new_sta(struct atheros_driver_data *drv, u8 addr[IEEE80211_ADDR_LEN])
 
 #ifdef ATH_WPS_IE
 	/* if WPS IE is present, preference is given to WPS */
-	if (ie.wps_ie &&
-	    (ie.wps_ie[1] > 0 && (ie.wps_ie[0] == WLAN_EID_VENDOR_SPECIFIC))) {
+	if (ie.wps_ie[0] == WLAN_EID_VENDOR_SPECIFIC && ie.wps_ie[1] > 0) {
 		iebuf = ie.wps_ie;
 		ielen = ie.wps_ie[1];
 	}