From: Arne Schwabe Date: Sun, 27 Nov 2022 08:59:33 +0000 (+0100) Subject: fix warning with gcc 12.2.0 (compiler bug?) X-Git-Tag: v2.7_alpha1~440 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5ad793e8cab8fcccae93fe9442eca6a6de8c044c;p=thirdparty%2Fopenvpn.git fix warning with gcc 12.2.0 (compiler bug?) Changing the argument of check_malloc_return from const void* to void* removes the warning from gcc 12.2.0: In file included from ../../../openvpn-git/src/openvpn/crypto_openssl.c:40: ../../../openvpn-git/src/openvpn/buffer.h: In function ‘hmac_ctx_new’: ../../../openvpn-git/src/openvpn/buffer.h:1030:9: warning: ‘ctx’ may be used uninitialized [-Wmaybe-uninitialized] 1030 | check_malloc_return((dptr) = (type *) malloc(sizeof(type))); \ | ^~~~~~~~~~~~~~~~~~~ ../../../openvpn-git/src/openvpn/buffer.h:1076:1: note: by argument 1 of type ‘const void *’ to ‘check_malloc_return’ declared here 1076 | check_malloc_return(const void *p) | ^~~~~~~~~~~~~~~~~~~ This more a quick fix/heads up for other people encountering the issue on GCC 12.2.0 like on Ubuntu 22.10 until we figure out if this is a bug in our code or a compiler bug. Signed-off-by: Arne Schwabe Acked-by: Heiko Hund Message-Id: <20221127085933.3487177-1-arne@rfc2549.org> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25549.html Signed-off-by: Gert Doering --- diff --git a/src/openvpn/buffer.h b/src/openvpn/buffer.h index 2461a2070..4cc79507e 100644 --- a/src/openvpn/buffer.h +++ b/src/openvpn/buffer.h @@ -1086,7 +1086,7 @@ gc_reset(struct gc_arena *a) } static inline void -check_malloc_return(const void *p) +check_malloc_return(void *p) { if (!p) {