From: drh <>
Date: Fri, 27 May 2022 18:06:49 +0000 (+0000)
Subject: Mark an always-true conditional as ALWAYS().
X-Git-Tag: version-3.39.0~84
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5af8a86d6280559fcecc4b5e65be4f8cadcb1888;p=thirdparty%2Fsqlite.git

Mark an always-true conditional as ALWAYS().

FossilOrigin-Name: 3492fe8a212cbe02b9016866e2499b99c3b566a4b0bc91fba267e6e1fe1b8943
---

diff --git a/manifest b/manifest
index b288ab3fe6..f69de28b39 100644
--- a/manifest
+++ b/manifest
@@ -1,5 +1,5 @@
-C Minor\ssimplification\sto\sALTER\sTABLE\slogic.
-D 2022-05-27T17:36:21.337
+C Mark\san\salways-true\sconditional\sas\sALWAYS().
+D 2022-05-27T18:06:49.146
 F .fossil-settings/empty-dirs dbb81e8fc0401ac46a1491ab34a7f2c7c0452f2f06b54ebb845d024ca8283ef1
 F .fossil-settings/ignore-glob 35175cdfcf539b2318cb04a9901442804be81cd677d8b889fcc9149c21f239ea
 F LICENSE.md df5091916dbb40e6e9686186587125e1b2ff51f022cc334e886c19a0e9982724
@@ -567,7 +567,7 @@ F src/printf.c 6166a30417b05c5b2f82e1f183f75faa2926ad60531c0b688a57dbc951441a20
 F src/random.c 097dc8b31b8fba5a9aca1697aeb9fd82078ec91be734c16bffda620ced7ab83c
 F src/resolve.c a4eb3c617027fd049b07432f3b942ea7151fa793a332a11a7d0f58c9539e104f
 F src/rowset.c ba9515a922af32abe1f7d39406b9d35730ed65efab9443dc5702693b60854c92
-F src/select.c a0dca0b4a328826d4713195a2fe305852cd8b1ed876311667b00c64b93a7fe23
+F src/select.c 7a4c5023d6c3bcd243546dbe9bbf5b280a60ca565658d037b8c0ec8dd77e1136
 F src/shell.c.in b76e681f9e441928d574f21f9473ef615158bbeab1ae49f05ecab9d81730a51d
 F src/sqlite.h.in 172528c287399a34f188154017b7268bf82c6d5b780902e361958d2318c4e37c
 F src/sqlite3.rc 5121c9e10c3964d5755191c80dd1180c122fc3a8
@@ -1970,8 +1970,8 @@ F vsixtest/vsixtest.tcl 6a9a6ab600c25a91a7acc6293828957a386a8a93
 F vsixtest/vsixtest.vcxproj.data 2ed517e100c66dc455b492e1a33350c1b20fbcdc
 F vsixtest/vsixtest.vcxproj.filters 37e51ffedcdb064aad6ff33b6148725226cd608e
 F vsixtest/vsixtest_TemporaryKey.pfx e5b1b036facdb453873e7084e1cae9102ccc67a0
-P db742e3e7d1caeff8d9df1d86abf54fcb2f2263db7a433ffacf3cd3777e533c5
-R 9f5bbbd598c3c632a4687a11d52f0b0c
+P 01beb0365c529481605f1864b1b6760e2484fad08d56a72e00e34acff37e23f8
+R 01dd885cb493be38067a73be4179a0ab
 U drh
-Z bcb40d0c984d7fab2c03d3331d81ea89
+Z 416cd8c7c7dc19c9e93e8237f3081073
 # Remove this line to create a well-formed Fossil manifest.
diff --git a/manifest.uuid b/manifest.uuid
index 0fa9a0e804..d26e133969 100644
--- a/manifest.uuid
+++ b/manifest.uuid
@@ -1 +1 @@
-01beb0365c529481605f1864b1b6760e2484fad08d56a72e00e34acff37e23f8
\ No newline at end of file
+3492fe8a212cbe02b9016866e2499b99c3b566a4b0bc91fba267e6e1fe1b8943
\ No newline at end of file
diff --git a/src/select.c b/src/select.c
index 57f1b45957..cc5e4df8db 100644
--- a/src/select.c
+++ b/src/select.c
@@ -2193,10 +2193,11 @@ int sqlite3ColumnsFromExprList(
       }
       if( pColExpr->op==TK_COLUMN
        && ALWAYS( ExprUseYTab(pColExpr) )
-       && (pTab = pColExpr->y.pTab)!=0
+       && ALWAYS( pColExpr->y.pTab!=0 )
       ){
         /* For columns use the column name name */
         int iCol = pColExpr->iColumn;
+        pTab = pColExpr->y.pTab;
         if( iCol<0 ) iCol = pTab->iPKey;
         zName = iCol>=0 ? pTab->aCol[iCol].zCnName : "rowid";
       }else if( pColExpr->op==TK_ID ){