From: stephan <stephan@noemail.net>
Date: Fri, 12 Aug 2022 17:55:18 +0000 (+0000)
Subject: Minor wasm-related doc clarification and remove an obsolete code comment.
X-Git-Tag: version-3.40.0~242
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5b0e63eb4c58a9ceb5c6d0d817ab34e75b02c001;p=thirdparty%2Fsqlite.git

Minor wasm-related doc clarification and remove an obsolete code comment.

FossilOrigin-Name: 1b1f650a08da93da97ed3a96b9a3e4eac567472c266188c02a9bffe1cf620e53
---

diff --git a/ext/wasm/api/README.md b/ext/wasm/api/README.md
index 025c9afc38..43d2b0dd5d 100644
--- a/ext/wasm/api/README.md
+++ b/ext/wasm/api/README.md
@@ -31,7 +31,7 @@ browser client:
   the next step can pass in a config object which abstracts away parts
   of the WASM environment, to facilitate plugging it in to arbitrary
   WASM toolchains.
-- `whwasmutil.js`\  
+- `../common/whwasmutil.js`\  
   A semi-third-party collection of JS/WASM utility code intended to
   replace much of the Emscripten glue. The sqlite3 APIs internally use
   these APIs instead of their Emscripten counterparts, in order to be
@@ -40,7 +40,7 @@ browser client:
   toolchains. It is "semi-third-party" in that it was created in order
   to support this tree but is standalone and maintained together
   with...
-- `jaccwabyt.js`\  
+- `../jaccwabyt/jaccwabyt.js`\  
   Another semi-third-party API which creates bindings between JS
   and C structs, such that changes to the struct state from either JS
   or C are visible to the other end of the connection. This is also an
diff --git a/ext/wasm/testing1.js b/ext/wasm/testing1.js
index e4b0882644..a733156e7a 100644
--- a/ext/wasm/testing1.js
+++ b/ext/wasm/testing1.js
@@ -325,15 +325,7 @@
         //log("int64_min/max() =",minMaxI64, typeof minMaxI64[0]);
         w.xCall('jaccwabyt_test_int64_minmax', pMin, pMax);
         T.assert(g64(pMin) === minMaxI64[0], "int64 mismatch").
-          assert(g64(pMax) === minMaxI64[1], "int64 mismatch")
-        /* ^^^ that will fail, as of this writing, due to
-           mismatched getMemValue()/setMemValue() impls in the
-           Emscripten-generated glue.  We install a
-           replacement getMemValue() in sqlite3-api.js to work
-           around that bug:
-
-           https://github.com/emscripten-core/emscripten/issues/17322
-        */;
+          assert(g64(pMax) === minMaxI64[1], "int64 mismatch");
         //log("pMin",g64(pMin), "pMax",g64(pMax));
         w.setMemValue(pMin, minMaxI64[0], ptrType64);
         T.assert(g64(pMin) === minMaxI64[0]).
@@ -348,7 +340,7 @@
         log("No BigInt support. Skipping related tests.");
         log("\"The problem\" here is that we can manipulate, at the byte level,",
             "heap memory to set 64-bit values, but we can't get those values",
-            "back into JS because of the lack of 64-bit number support.");
+            "back into JS because of the lack of 64-bit integer support.");
       }
     }finally{
       const x = w.scopedAlloc(1), y = w.scopedAlloc(1), z = w.scopedAlloc(1);
diff --git a/manifest b/manifest
index a34ccd1ec5..ef72de5c1d 100644
--- a/manifest
+++ b/manifest
@@ -1,5 +1,5 @@
-C wasm:\sdocument\sthe\srole\sof\ssqlite3-wasm.c.\sOther\sminor\sdoc\supdates.
-D 2022-08-12T13:07:21.618
+C Minor\swasm-related\sdoc\sclarification\sand\sremove\san\sobsolete\scode\scomment.
+D 2022-08-12T17:55:18.237
 F .fossil-settings/empty-dirs dbb81e8fc0401ac46a1491ab34a7f2c7c0452f2f06b54ebb845d024ca8283ef1
 F .fossil-settings/ignore-glob 35175cdfcf539b2318cb04a9901442804be81cd677d8b889fcc9149c21f239ea
 F LICENSE.md df5091916dbb40e6e9686186587125e1b2ff51f022cc334e886c19a0e9982724
@@ -478,7 +478,7 @@ F ext/wasm/GNUmakefile 5359a37fc13b68fad2259228590450339a0c59687744edd0db7bb93d3
 F ext/wasm/README.md 4b00ae7c7d93c4591251245f0996a319e2651361013c98d2efb0b026771b7331
 F ext/wasm/api/EXPORTED_FUNCTIONS.sqlite3-api c5eaceabb9e759aaae7d3101a4a3e542f96ab2c99d89a80ce20ec18c23115f33
 F ext/wasm/api/EXPORTED_RUNTIME_METHODS.sqlite3-api 1ec3c73e7d66e95529c3c64ac3de2470b0e9e7fbf7a5b41261c367cf4f1b7287
-F ext/wasm/api/README.md b3c502bda9a7da0621edcbbd055b9c498a0cfed09ffed59aa026461e6e514ed1
+F ext/wasm/api/README.md b6d0fb64bfdf7bf9ce6938ea4104228f6f5bbef600f5d910b2f8c8694195988c
 F ext/wasm/api/post-js-footer.js b64319261d920211b8700004d08b956a6c285f3b0bba81456260a713ed04900c
 F ext/wasm/api/post-js-header.js 0e853b78db83cb1c06b01663549e0e8b4f377f12f5a2d9a4a06cb776c003880b
 F ext/wasm/api/sqlite3-api-cleanup.js 149fd63a0400cd1d69548887ffde2ed89c13283384a63c2e9fcfc695e38a9e11
@@ -503,7 +503,7 @@ F ext/wasm/jaccwabyt/jaccwabyt.md 447cc02b598f7792edaa8ae6853a7847b8178a18ed356a
 F ext/wasm/jaccwabyt/jaccwabyt_test.c 39e4b865a33548f943e2eb9dd0dc8d619a80de05d5300668e9960fff30d0d36f
 F ext/wasm/jaccwabyt/jaccwabyt_test.exports 5ff001ef975c426ffe88d7d8a6e96ec725e568d2c2307c416902059339c06f19
 F ext/wasm/testing1.html 0bf3ff224628c1f1e3ed22a2dc1837c6c73722ad8c0ad9c8e6fb9e6047667231
-F ext/wasm/testing1.js aef553114aada187eef125f5361fd1e58bf5e8e97acfa65c10cb41dd60295daa
+F ext/wasm/testing1.js cba7134901a965743fa9289d82447ab71de4690b1ee5d06f6cb83e8b569d7943
 F ext/wasm/testing2.html 73e5048e666fd6fb28b6e635677a9810e1e139c599ddcf28d687c982134b92b8
 F ext/wasm/testing2.js d37433c601f88ed275712c1cfc92d3fb36c7c22e1ed8c7396fb2359e42238ebc
 F install-sh 9d4de14ab9fb0facae2f48780b874848cbf2f895 x
@@ -1999,8 +1999,8 @@ F vsixtest/vsixtest.tcl 6a9a6ab600c25a91a7acc6293828957a386a8a93
 F vsixtest/vsixtest.vcxproj.data 2ed517e100c66dc455b492e1a33350c1b20fbcdc
 F vsixtest/vsixtest.vcxproj.filters 37e51ffedcdb064aad6ff33b6148725226cd608e
 F vsixtest/vsixtest_TemporaryKey.pfx e5b1b036facdb453873e7084e1cae9102ccc67a0
-P 06b6113783dd81252a5dd125e1cddb52a9d4e387c74cfb3ba88475e47a31060a
-R a62abfa1bd7be911f96cf33e0210940f
+P 4c10b9b18feca82440273f8192fef951ad051bbfd8aad4d3c840cf6375130afd
+R 3e055b525bbc2100d8c4c001b630489b
 U stephan
-Z 65285bd6e6db388430367f6dfb4bd451
+Z 4d766400503717808861a1e631c17801
 # Remove this line to create a well-formed Fossil manifest.
diff --git a/manifest.uuid b/manifest.uuid
index 2d231af8ed..911760f4e7 100644
--- a/manifest.uuid
+++ b/manifest.uuid
@@ -1 +1 @@
-4c10b9b18feca82440273f8192fef951ad051bbfd8aad4d3c840cf6375130afd
\ No newline at end of file
+1b1f650a08da93da97ed3a96b9a3e4eac567472c266188c02a9bffe1cf620e53
\ No newline at end of file