From: Jaegeuk Kim <jaegeuk@kernel.org>
Date: Fri, 4 May 2018 06:26:02 +0000 (-0700)
Subject: f2fs: avoid fsync() failure caused by EAGAIN in writepage()
X-Git-Tag: v4.18-rc1~58^2~72
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5b19d284f5195a925dd015a6397bfce184097378;p=thirdparty%2Flinux.git

f2fs: avoid fsync() failure caused by EAGAIN in writepage()

pageout() in MM traslates EAGAIN, so calls handle_write_error()
 -> mapping_set_error() -> set_bit(AS_EIO, ...).
 file_write_and_wait_range() will see EIO error, which is critical
 to return value of fsync() followed by atomic_write failure to user.

Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 5477fc09c3cdf..ac8720fa5868b 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -1904,7 +1904,13 @@ out:
 
 redirty_out:
 	redirty_page_for_writepage(wbc, page);
-	if (!err)
+	/*
+	 * pageout() in MM traslates EAGAIN, so calls handle_write_error()
+	 * -> mapping_set_error() -> set_bit(AS_EIO, ...).
+	 * file_write_and_wait_range() will see EIO error, which is critical
+	 * to return value of fsync() followed by atomic_write failure to user.
+	 */
+	if (!err || wbc->for_reclaim)
 		return AOP_WRITEPAGE_ACTIVATE;
 	unlock_page(page);
 	return err;