From: Amos Jeffries <squid3@treenet.co.nz>
Date: Mon, 18 Oct 2010 11:49:19 +0000 (+1300)
Subject: Bug 3078: crashes repeatedly after rebuilding the cache
X-Git-Tag: take1~167
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5b1d04af7259f10bb37e8e8c057955a2265ab104;p=thirdparty%2Fsquid.git

Bug 3078: crashes repeatedly after rebuilding the cache

Regression from must-revalidate HTTP/1.1 compliance fixes.
Only flag refresh/revalidation failure when client request is present.
---

diff --git a/src/refresh.cc b/src/refresh.cc
index dbf6c2e107..b977e226bd 100644
--- a/src/refresh.cc
+++ b/src/refresh.cc
@@ -289,7 +289,8 @@ refreshCheck(const StoreEntry * entry, HttpRequest * request, time_t delta)
 #endif
        ) {
         debugs(22, 3, "refreshCheck: YES: Must revalidate stale response");
-        request->flags.fail_on_validation_err = 1;
+        if (request)
+            request->flags.fail_on_validation_err = 1;
         return STALE_MUST_REVALIDATE;
     }