From: Volker Lendecke Date: Tue, 13 May 2025 09:31:12 +0000 (+0200) Subject: libsmb: Slightly clarify format in set/get_secdesc X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5b28822d9be81dae7a8341cc359c6e79498df241;p=thirdparty%2Fsamba.git libsmb: Slightly clarify format in set/get_secdesc We have reserved fields after those 16-bit ones. With little endian those are set to 0 with PUSH_LE32. That is unnecessary here, the fields are already set to 0. This patch is not for efficiency, I just got a bit confused by the subtlety. Signed-off-by: Volker Lendecke Reviewed-by: Anoop C S --- diff --git a/source3/libsmb/clisecdesc.c b/source3/libsmb/clisecdesc.c index 32558c148c9..e6c31cfb49f 100644 --- a/source3/libsmb/clisecdesc.c +++ b/source3/libsmb/clisecdesc.c @@ -69,7 +69,8 @@ struct tevent_req *cli_query_security_descriptor_send( return req; } - PUSH_LE_U32(state->param, 0, fnum); + PUSH_LE_U16(state->param, 0, fnum); + /* 2 bytes reserved, set to 0 by tevent_req_create */ PUSH_LE_U32(state->param, 4, sec_info); subreq = cli_trans_send( @@ -268,8 +269,9 @@ struct tevent_req *cli_set_security_descriptor_send( return req; } - SIVAL(state->param, 0, fnum); - SIVAL(state->param, 4, sec_info); + PUSH_LE_U16(state->param, 0, fnum); + /* 2 bytes reserved, set to 0 by tevent_req_create */ + PUSH_LE_U32(state->param, 4, sec_info); subreq = cli_trans_send( state, /* mem_ctx */