From: Jose E. Marchesi Date: Mon, 31 Jul 2023 13:44:36 +0000 (+0200) Subject: bpf: opcodes: fix regression in BPF disassembler X-Git-Tag: binutils-2_41-release~33 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5b512234c874d5f82734dc6115765bc691c2c982;p=thirdparty%2Fbinutils-gdb.git bpf: opcodes: fix regression in BPF disassembler This patch fixes a regression recently introduced in the BPF disassembler, that was assuming an abfd was always available in info->section->owner. Apparently this is not so in GDB, and therefore https://sourceware.org/bugzilla/show_bug.cgi?id=30705. Tested in bpf-unkonwn-none. opcodes/ChangeLog: 2023-07-31 Jose E. Marchesi PR 30705 * bpf-dis.c (print_insn_bpf): Check that info->section->owner is actually available before using it. --- diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog index 9d33da21627..99f95c64568 100644 --- a/opcodes/ChangeLog +++ b/opcodes/ChangeLog @@ -1,3 +1,9 @@ +2023-07-31 Jose E. Marchesi + + PR 30705 + * bpf-dis.c (print_insn_bpf): Check that info->section->owner is + actually available before using it. + 2023-07-30 Jose E. Marchesi * bpf-dis.c: Initialize asm_bpf_version to -1. diff --git a/opcodes/bpf-dis.c b/opcodes/bpf-dis.c index a8cb9e8e6db..1b1a532df74 100644 --- a/opcodes/bpf-dis.c +++ b/opcodes/bpf-dis.c @@ -147,7 +147,7 @@ print_insn_bpf (bfd_vma pc, disassemble_info *info) If the user didn't explicitly specify an ISA version, then derive it from the CPU Version flag in the ELF header. A CPU version of 0 in the header means "latest version". */ - if (asm_bpf_version == -1) + if (asm_bpf_version == -1 && info->section && info->section->owner) { struct bfd *abfd = info->section->owner; Elf_Internal_Ehdr *header = elf_elfheader (abfd);