From: Karan Tilak Kumar Date: Mon, 6 Jan 2025 22:44:49 +0000 (-0800) Subject: scsi: fnic: Remove unnecessary else and unnecessary break in FDLS X-Git-Tag: v6.14-rc1~80^2^2~9 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5b6179d4b661e3c22ffa5f3fe2523bad4cd01983;p=thirdparty%2Fkernel%2Flinux.git scsi: fnic: Remove unnecessary else and unnecessary break in FDLS Incorporate review comments from Martin: Remove unnecessary else and unnecessary break to fix warnings in the FDLS code. Reviewed-by: Sesidhar Baddela Reviewed-by: Arulprabhu Ponnusamy Reviewed-by: Gian Carlo Boffa Reviewed-by: Arun Easi Signed-off-by: Karan Tilak Kumar Link: https://lore.kernel.org/r/20250106224451.3597-1-kartilak@cisco.com Signed-off-by: Martin K. Petersen --- diff --git a/drivers/scsi/fnic/fdls_disc.c b/drivers/scsi/fnic/fdls_disc.c index 2534af2fff53e..2513a82a89152 100644 --- a/drivers/scsi/fnic/fdls_disc.c +++ b/drivers/scsi/fnic/fdls_disc.c @@ -2776,23 +2776,19 @@ fdls_process_tgt_prli_rsp(struct fnic_iport_s *iport, /*Retry Plogi again from the timer routine. */ tport->flags |= FNIC_FDLS_RETRY_FRAME; return; - } else { - FNIC_FCS_DBG(KERN_INFO, fnic->host, fnic->fnic_num, - "PRLI returned ELS_LS_RJT from target: 0x%x", - tgt_fcid); - - fdls_tgt_logout(iport, tport); - fdls_delete_tport(iport, tport); - return; } - break; + FNIC_FCS_DBG(KERN_INFO, fnic->host, fnic->fnic_num, + "PRLI returned ELS_LS_RJT from target: 0x%x", + tgt_fcid); + fdls_tgt_logout(iport, tport); + fdls_delete_tport(iport, tport); + return; default: atomic64_inc(&iport->iport_stats.tport_prli_misc_rejects); FNIC_FCS_DBG(KERN_INFO, fnic->host, fnic->fnic_num, "PRLI not accepted from target: 0x%x", tgt_fcid); return; - break; } FNIC_FCS_DBG(KERN_INFO, fnic->host, fnic->fnic_num,