From: Alberto Leiva Popper <ydahhrk@gmail.com>
Date: Thu, 24 Jun 2021 19:09:31 +0000 (-0500)
Subject: Main: Add a result code sanitizer
X-Git-Tag: v1.5.1~9
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5b782a0398a10544748a6ec272bd6e3a34ab4911;p=thirdparty%2FFORT-validator.git

Main: Add a result code sanitizer

Improves the exit status code.
---

diff --git a/src/main.c b/src/main.c
index 89cda311..790f2a37 100644
--- a/src/main.c
+++ b/src/main.c
@@ -29,6 +29,39 @@ run_rtr_server(void)
 	return error;
 }
 
+/**
+ * Shells don't like it when we return values other than 0-255.
+ * In fact, bash also has its own meanings for 126-255.
+ * (See man 1 bash > EXIT STATUS)
+ *
+ * This function shifts @error to our exclusive range.
+ */
+static int
+convert_to_result(int error)
+{
+	if (error == 0)
+		return 0; /* Happy path */
+
+	/* -INT_MIN overflows, So handle weird case. */
+	if (error == INT_MIN)
+		return 125;
+
+	/* Force range 0-127 */
+	if (error < 0)
+		error = -error;
+	error &= 0x7F;
+
+	switch (error) {
+	case 126:
+		return 122;
+	case 127:
+		return 123;
+	case 0:
+		return 124; /* was divisible by 128; force error. */
+	}
+	return error;
+}
+
 int
 main(int argc, char **argv)
 {
@@ -115,5 +148,5 @@ revert_config:
 revert_log:
 	log_teardown();
 just_quit:
-	return abs(error);
+	return convert_to_result(error);
 }